Add a test for not interpolating rendered section output #32
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very interesting test, quite related to issue #19. |
|
Good catch on both this and #31; the latter is covered implicitly (read: accidentally) by the specs for dotted names, but both of these are clearly oversights in the spec at large. I'll get these merged into both the v1.0.x and v1.1.x specs soon. Thanks! |
|
Thanks, @pvande and @groue. groue, on the subject of related issues, I arrived at this test case in the process of thinking about issue #30 -- specifically the order in which lambdas should be evaluated that occur in nested sections (descending towards the leaves in the depth-first traversal or ascending up from them). I may have one more test case to offer that is similarly related -- on the subject of lambdas. |
cjerdonek
added a commit
to cjerdonek/mustache-spec
that referenced
this pull request
May 3, 2012
…development See issue mustache#32: mustache#32
pombredanne
pushed a commit
to pombredanne/pystache
that referenced
this pull request
Nov 1, 2013
The two test cases test, respectively, (1) context precedence and (2) that section output not be rendered. The two test cases were originally proposed for inclusion in the Mustache spec test cases in mustache/spec issues defunkt#31 and defunkt#32: * mustache/spec#31 * mustache/spec#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to lambda return values, the output of rendering a section should not be parsed. I think a test case would be helpful here to draw a distinction with that behavior. Test case included.
The attached test case would also clarify that nested sections should be evaluated "outside-in" rather than "inside-out." For example--